Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557776 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-01-24 14:15:18 EST --- Some notes for 1.5-3 * Compilar flags - "CFLAGS="$RPM_OPT_FLAGS"" in "make %{?_smp_mflags}" is not needed. configure generated by recent autotools acknowledges CFLAGS environment and %configure sets this. Please check what %configure actually does by $ rpm --eval %configure . * Timestamp - Please consider to use -------------------------------------------------------------------- %{__make} install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p" -------------------------------------------------------------------- to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools. * %defattr - Now we prefer to use %defattr(-,root,root,-) * File placement - As the Summary of the main package already says "low-level C software *development* kit", I don't see strict necessity for putting two binaries into -devel package. - Also "README" should usually be packaged in main package. * %changelog - It is recommended to put one line between each %changelog entry like below because it is useful on Fedora CVS --------------------------------------------------------------------- * Sun Jan 24 2010 - Maxim Burgerhout <maxim@xxxxxxxxx> - 1.5-3 - Took out the dep on libusb1-devel - Moved README doc to -devel: it's mostly about ykdebug and modhex * Sun Jan 24 2010 - Maxim Burgerhout <maxim@xxxxxxxxx> - 1.5-2 - Used macros in Source0 - URL no longer point to redirect - Removed INSTALL from documentation - Moved modhex and ykdebug to -devel - Inserted compilerflags - Inserted INSTALLFLAGS to keep timestamps - Some more macros for make and sed * Wed Jan 20 2010 - Maxim Burgerhout <maxim@xxxxxxxxx> - 1.5-1 - First packaged release --------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review