Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557776 Akio Idehara <zbe64533@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbe64533@xxxxxxxxx --- Comment #1 from Akio Idehara <zbe64533@xxxxxxxxx> 2010-01-23 22:44:07 EST --- Hello. Here are some note: (1) Documentation - "rpmlint" says "libyubikey-devel.i686: W: no-documentation". - Pay attention about which subpackage you include documentation in, for example API documentation belongs in the -devel subpackage, not the main one. * http://fedoraproject.org/wiki/Packaging/Guidelines#Documentation (2) Compiler flags - Compilers used to build packages should honor the applicable compiler flags set in the system rpm configuration. * http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags - $RPM_OPT_FLAGS or %{optflags} for C, C++, and Fortran compilers. (3) Timestamps - Please keep timestamps on installed files as much as possible: * http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps - When using "cp" or "install" commands add "-p" option - Also please consider to add 'INSTALLFLAGS="-c -p"' to "make install" (4) URL - The URL and the Source0 is old (redirected), please keep the latest URL. * "http://code.google.com/p/yubico-c/"; (5) binary files - If the software being packaged contains files intended solely for development, those files should be put in a -devel subpackage. * http://fedoraproject.org/wiki/Packaging/Guidelines#Devel_Packages o %{_bindir}/modhex o %{_bindir}/ykdebug (6) pkgconfig file - This library does not have pkgconfig file(.pc), so "BuildRequires: pkgconfig" is needless. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review