Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554090 Eric Smith <eric@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric@xxxxxxxxxxxx --- Comment #1 from Eric Smith <eric@xxxxxxxxxxxx> 2010-01-23 22:52:26 EST --- I'm not yet sponsored as a packager, but here's an unofficial review: The Require: tag is no longer necessary, or allowed. rpmlint output: sugar-physics.spec:6: W: non-standard-group Sugar/Activities sugar-physics.noarch: W: non-standard-group Sugar/Activities 1 packages and 1 specfiles checked; 0 errors, 2 warnings. I'm fairly sure I remember seeing a requirement that the Group: tag come from the official list in /usr/share/doc/rpm-*/GROUPS, but I can't find that in the packaging guidellines now, and the Sugar packaging guidelines use Sugar/Activities just as you have, so I guess that's allowed. source tarball verified against upstream compiles and builds on F12 x86_64 and i386 using mock I attempted to verify minimal functionality using sugar-emulator. When I start the physics activity, I get a pulsating logo, but nothing else seems to happen for quite a while, then it dumps me back to the activity list. It's entirely possible that I'm doing something wrong. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review