Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554090 --- Comment #2 from Sebastian Dziallas <sebastian@xxxxxxxx> 2010-01-24 11:46:27 EST --- Thanks for taking on this one! :) (In reply to comment #1) > I'm not yet sponsored as a packager, but here's an unofficial review: > > The Require: tag is no longer necessary, or allowed. Well, since this is a Python package we still need to use the Requires tag, as the dependencies don't get added here automagically. > rpmlint output: > sugar-physics.spec:6: W: non-standard-group Sugar/Activities > sugar-physics.noarch: W: non-standard-group Sugar/Activities > 1 packages and 1 specfiles checked; 0 errors, 2 warnings. > > I'm fairly sure I remember seeing a requirement that the Group: tag come from > the official list in /usr/share/doc/rpm-*/GROUPS, but I can't find that in the > packaging guidellines now, and the Sugar packaging guidelines use > Sugar/Activities just as you have, so I guess that's allowed. Yes, this is common practice among the Sugar Activity packages and in the guidelines here: http://fedoraproject.org/wiki/Packaging:SugarActivityGuidelines#Sample_SPEC > source tarball verified against upstream > compiles and builds on F12 x86_64 and i386 using mock > > I attempted to verify minimal functionality using sugar-emulator. When I start > the physics activity, I get a pulsating logo, but nothing else seems to happen > for quite a while, then it dumps me back to the activity list. It's entirely > possible that I'm doing something wrong. Oh yeah, I see. Looks like I'm missing another requirement (I had it already installed when giving it some initial testing). After installing python-olpcgames, you should be good to go. I'll add it to the next release bump. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review