Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dwdiff - Front end to diff for comparing files on a word per word basis https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209608 jhrozek@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(jhrozek@xxxxxxxxxx| |) | ------- Additional Comments From jhrozek@xxxxxxxxxx 2006-10-07 15:11 EST ------- >> BAD: Use full url on Source0 >> BAD: Use either $RPM_BUILD_ROOT + $RPM_OPT_FLAGS or the macros, not both. >> BAD: See packaging guidelines how to use %find_lang to package the >> localizations. Thanks, fixed >> >> It should Requires diffutils. Fixed, I've ommited it because of http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions but you're right that that document mentions BuildRequires not Requires >> >> It must BuildRequires at least gettext and diffutils (as diff is checked by >> the configure program) You're right about gettext, sorry, fixed. I'm aware of the fact that the package uses diff but according to http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions there's no need to include diffutils in the BuildRequires section. >> >> Next time read http://fedoraproject.org/wiki/Packaging/Guidelines Thanks for reviewing the package! packages that should fix the above problems are located at: spec URL: http://www.stud.fit.vutbr.cz/~xhroze01/dwdiff/dwdiff.spec SRPM URL: http://www.stud.fit.vutbr.cz/~xhroze01/dwdiff/dwdiff-1.2-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review