Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xorg-x11-xcalc - X.org XCalc https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204513 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2006-10-07 16:10 EST ------- The version number seems to be 1.0.1 from configure.ac. So, no need to have X11R7.0. * There could be the word calculator in the summary, it is a bit terse currently * you should add the version to the Provides: xcalc * a dot should end the description * the Requires aren't needed for libs, they should be autodetected * are you sure xorg-x11-xbitmaps is needed? * are all the buildrequires really needed? For example libXdmcp-devel don't seems to be needed to me. indirect buildrequires are optional. * the Changelog could be in %doc * in %files macros should be used there is also W: xorg-x11-xcalc strange-permission xcalc-X11R7.0-1.0.1.tar.bz2 0600 To be sponsored, you should have a look at http://fedoraproject.org/wiki/Extras/HowToGetSponsored -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review