Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dwdiff - Front end to diff for comparing files on a word per word basis https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209608 tmraz@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(jhrozek@xxxxxxxxxx | |) ------- Additional Comments From tmraz@xxxxxxxxxx 2006-10-06 14:36 EST ------- GOOD: No rpmlint warnings or errors. BAD: Use full url on Source0 BAD: Use either $RPM_BUILD_ROOT + $RPM_OPT_FLAGS or the macros, not both. BAD: See packaging guidelines how to use %find_lang to package the localizations. It should Requires diffutils. It must BuildRequires at least gettext and diffutils (as diff is checked by the configure program) Next time read http://fedoraproject.org/wiki/Packaging/Guidelines -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review