Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548522 Till Maas <opensource@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx --- Comment #4 from Till Maas <opensource@xxxxxxxxx> 2010-01-11 08:10:39 EST --- The remarks about the patches you gave in comment:2 should go in the spec as comments near the PatchX lines. Why do you set the default owner/group to autotest? It seems to be wrong, e.g. /usr/share/doc/autotest-client-0.11.0/LICENSE does certainly not need to be owned by autotest:autotest. Also the directory structure does not seem clean, e.g. I guess /usr/share/autotest/client/bin/autotest should go to /usr/bin/autotest. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review