Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548522 --- Comment #5 from James Laska <jlaska@xxxxxxxxxx> 2010-01-11 14:21:39 EST --- (In reply to comment #4) > The remarks about the patches you gave in comment:2 should go in the spec as > comments near the PatchX lines. Okay, as directed, I've added my comments to the autotest-client.spec file. See updated autotest-client.spec - http://jlaska.fedorapeople.org/autoqa/autotest-client.spec > Why do you set the default owner/group to autotest? It seems to be wrong, e.g. > /usr/share/doc/autotest-client-0.11.0/LICENSE does certainly not need to be > owned by autotest:autotest. > > Also the directory structure does not seem clean, e.g. I guess > /usr/share/autotest/client/bin/autotest should go to /usr/bin/autotest. Unfortunately, it cannot be fully packaged as you might expect new software to be packaged in Fedora. Autotest is packaged upstream such that *everything* lives in it's own root-directory (much like other web-services like mediawiki or moin). The source-code for autotest expects this. We investigated carrying patches and moving content into a directory structure that was more familiar to most people, however that patchset would be *enormous*. I can change the default owner back to root:root, and identify the exactly sub-directories that autotest requires write access to if you prefer. But it may not be possible to have everything root:root under /usr/share/autotest for autotest-client. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review