Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551258 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-01-11 08:06:37 EST --- > Name: libgcal > Group: Development/Libraries The base shared library still belongs into "System Environment/Libraries". > %doc COPYING > %doc INSTALL > %doc README > %doc Changelog.txt You can put multiple files behind a single %doc. File "INSTALL" is irrelevant to RPM package users. > %postun > /sbin/ldconfig > > #--------------------------------------------------------------------------------- > %package devel Caution! Avoid '#comments' after scriptlet sections. They would be included as scriptlet bodies, which breaks -p /sbin/ldconfig for example. In this particular case, simply delete that silly #---- line. It doesn't serve any purpose and only causes trouble here. Then "%postun -p /sbin/ldconfig" will work again. $ rpm -qp --scripts libgcal-0.9.3-1.fc12.i686.rpm postinstall program: /sbin/ldconfig postuninstall scriptlet (using /bin/sh): /sbin/ldconfig #--------------------------------------------------------------------------------- > %description devel > > libgcal library Header Files and Link Libraries This description would benefit from some cleanup. Please make this a complete sentence in English. * Have you looked into enabling the built-in test-suite and creating a proper %check section for it? * The -devel packages depends on libxml and libcurl headers, so adding "Requires: libxml2-devel libcurl-devel" would be necessary for all targets that don't add automatic pkgconfig dependencies (Fedora 10 and older, EPEL 5 and older). If you want to rely on the automatic pkgconfig dependencies, you can drop the "Requires: pkgconfig". * The header files in libgcal-devel bear a huge risk of causing file conflicts. This is a blocker IMO. This library ought to install them into a libgcal sub-directory: $ rpmls -p libgcal-devel-0.9.3-1.fc12.i686.rpm -rw-r--r-- /usr/include/atom_parser.h -rw-r--r-- /usr/include/gcal.h -rw-r--r-- /usr/include/gcal_parser.h -rw-r--r-- /usr/include/gcal_status.h -rw-r--r-- /usr/include/gcalendar.h -rw-r--r-- /usr/include/gcont.h -rw-r--r-- /usr/include/gcontact.h -rw-r--r-- /usr/include/internal_gcal.h -rw-r--r-- /usr/include/xml_aux.h [...] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review