Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225769 --- Comment #8 from John Dennis <jdennis@xxxxxxxxxx> 2009-12-21 14:01:04 EDT --- Thank you for your careful review Peter. You're correct, there was no need for the freeradius-libs subpackage, I can't recall why it existed, possibly it was historic, I've removed it and added an Obsoletes for it. The subpackage dependencies were also upadated. You're correct, ldconfig is unnecessary. It's presence was part historic and part defensive. A somewhat common scenario with FreeRADIUS newbies is to grab the upstream tarball and build and install it themselves. They run into a number of problems because they didn't build and install it correctly so they query the support forum and are told to use prebuilt binaries, so they install the rpm's but they still have problems because they messed up ld from their initial unsuccessful attempts, then they are told to run ldconfig which clears up the problem for them. That's why running ldconfig was somewhat "defensive". However, your point about it being unnecessary is valid so I've removed it. I fixed the devel subpackage description. I removed the execute permissions on the source files. As for the 3 documentation files not being utf-8. The rlm_dbm and pppext-eap-sim-12 are getting triggered only for a contributor's name in the file. I spent about an hour trying to figure out what encoding these files were using but I couldn't, it'd definitely not iso-8859-1. If you use iconv to convert from iso-8859-1 to utf-8 on these files you'll discover they're not converted correctly. Since iconv doesn't produce the right result and between the two files it's only 3 characters in total which are bogus I don't see a point on running it if the only point is to eliminate the rpmlint message. The draft-sterman-aaa-sip-00.txt file is triggering the warning because the hyphen character used to break words during pagination is 0xED, it occurs only at the end of a line when a word is broken, it really doesn't affect ones ability to read the file, the errors occur on each copy of the file which showed up with a google search. It's within my comfort zone to ignore these utf-8 errors. These changes appear in the 2.1.7-6 version (not yet tagged or built, but in CVS) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review