Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225769 --- Comment #7 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-12-21 06:02:59 EDT --- Latest scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=1882750 As usual for such oldschool packages, there is a large list of rpmlint's complaints and warnings (most of them may be safely ignored in this particular case): http://peter.fedorapeople.org/freeradius-2.1.7-5_rpmlint.txt Here is a diff over my last rpmlint check: http://peter.fedorapeople.org/freeradius-2.1.7-5.diff I removed safe-to-ignore rpmlint messages, and here is a final report (I added numbers for the simplicity): [petro@Workplace i386]$ cat ~/fuse/sshfs/sulaco/home/petro/fuse/sshfs/fedora/public_html/freeradius-2.1.7-5_rpmlint.txt |grep -v non-readable|grep -v non-standard-dir-perm|grep -v no-documentation -n 1:freeradius.i686: W: incoherent-version-in-changelog 2.1.7-4 ['2.1.7-5.fc12', '2.1.7-5'] 2:freeradius.i686: W: file-not-utf8 /usr/share/doc/freeradius-2.1.7/rfc/draft-sterman-aaa-sip-00.txt 3:freeradius.i686: E: incoherent-logrotate-file /etc/logrotate.d/radiusd 4:freeradius.i686: W: file-not-utf8 /usr/share/doc/freeradius-2.1.7/rlm_dbm 5:freeradius.i686: W: file-not-utf8 /usr/share/doc/freeradius-2.1.7/rfc/pppext-eap-sim-12.txt 6:freeradius.i686: E: non-standard-executable-perm /etc/raddb/certs/bootstrap 0750 7:freeradius.i686: W: incoherent-init-script-name radiusd ('freeradius', 'freeradiusd') 8:freeradius-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/freeradius-server-2.1.7/src/modules/rlm_ippool/rlm_ippool_tool.c 9:freeradius-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/freeradius-server-2.1.7/src/modules/rlm_linelog/rlm_linelog.c 10:freeradius-debuginfo.i686: W: hidden-file-or-dir /usr/src/debug/freeradius-server-2.1.7/src/main/.libs 11:freeradius-debuginfo.i686: W: hidden-file-or-dir /usr/src/debug/freeradius-server-2.1.7/src/main/.libs 21:12 packages and 0 specfiles checked; 122 errors, 18 warnings. [petro@Workplace i386]$ 1. Easyfix - you simply forgot to add %changelog entry for the latest rebuild. 2. I can't find easily what encoding this file is encoded with. If you know, then, please. add convert it from this codepage to UTF-8 at %prep stage. 3. Due to historical reasons, the main application name differs from the package's name. We cannot change too much here, so this issue should be omitted. 4. Please, add iconv -f iso8859-1 to the %prep stage. 5. The same as for p.2. If you know how to convert it to UTF-8, please do it at the %prep stage. Otherwise simply postpone fixing it to the (not so) nearest future. 6. See my comment above. In short - looks like this should be placed here due to historical reasons. So this issue may be omitted too. 7. Likewise. 8. Please, change permissions to 0644 at the %prep stage. 9. Likewise. 10. I think this may be ignored. 11. Likewise. See also this link (for those, who interested in John's PoV on these issues): https://bugzilla.redhat.com/show_bug.cgi?id=487059#c3 I mostly agree with his reasons, however I'd like to see #1,8,9 fixed. Ok, that's all about rpmlint messages. Also I've got some complaints regarding various aspects iof the package itself: * The *-devel package's description is irrelevant to the sub-package's content. It doesn't contain any static libraries - just a C header files. * I don't see any development libraries in *devel sub-package (in fact I don't see any librarties in the common ldconfig paths, but that will be my next question). I suspect, that shared library objects in %{_libdir}/freeradius/ , which doesn't contain 2.1.7 in their names, should be placed in *-devel sub-package, but I'm not sure. Could you, please, comment on this. * As I already mentioned, I don;'t see any shared library objects, visible to ldconfig. So I pretty sure there is no need to run ldconfig. * As I told in my previous comment. I don't see rationale behind splitting main package to freeradius and freeradius-libs. Could you, please, comment on this. Citing myself: "In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}, but freeradius-devel requires freeradius-libs instead. However, I suspect, that there is some rationale behind this. Actually, I suspect also, that something is broken here, since these two libraries located not in any of the standart ldconfig paths." * And one more - I suggestion you to enable modules for dealing with firebird and iodbc (both are available in Fedora). Obviously, this only applies to Fedora. That's all so far. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review