Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225769 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-12-21 15:28:50 EDT --- Great. You fixed all blocking issues, and I have only few remaining non-blocking suggestions: * Since all sub-packages are requiring main freeradius package now, there is no need to try to create user/group radiusd at %pre stage while installing of any sub-package except main one (freeradius). * There is no need to explicitly mark man-pages as %doc * I'd like to introduce you the hidden directory creation power of 'install' utility. Instead of typing mkdir -p /my/path/ install file.ext /my/path/newfile.ext you may simply type install -D file.ext /my/path/newfile.ext and 'install' will create /my/path/ for you :) Anyway, these my suggestions won't dramatically change end user's experience with freeradius, so it's up to you to decide, whether or not to follow them. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review