Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477542 --- Comment #18 from Jaroslaw Gorny <jaroslaw.gorny@xxxxxxxxx> 2009-10-27 04:37:52 EDT --- Peter, find my answers below: (In reply to comment #17) > (In reply to comment #16) > > > @xandry: I changed this using %attr(). Now rpmlint does not complain. I've > > installed this package and file permissions are correct. > > First, I'm afraid, that you should package it as is, w/o changing permissions. > There is one possible user case - running mpdscribble as a server on an iron > with multiple user accounts, and server's admin would like to hide last.fs > account settings from others. > You're absolutely right. But on the other hand rpmlint is mandatory step in package approval. So how are we going to deal with it? > Second, I don't see a reason in using killall in %preun section. I think that > killing all instances of the app, started by other users, is somewhat improper. > Yes, your're right. I'll change this. I took this %preun scriptlet from wpa_supplicant package - it makes sense there ;) > Also, I advice you a little simplification. Instead of > > #init scripts > install -d $RPM_BUILD_ROOT/%{_sysconfdir}/rc.d/init.d > install -m 0755 %{SOURCE1} $RPM_BUILD_ROOT/%{_sysconfdir}/rc.d/init.d/%{name} > > you may write > > install -D -m 0755 %{SOURCE1} > $RPM_BUILD_ROOT/%{_sysconfdir}/rc.d/init.d/%{name} OK. I'll merge those two lines into one. > Please, note, that %{_initddir} is unavailable on RHEL/CentOS, so if you plan > to push the application into EPEL also, then you should consider using > %{_initrddir} instead. > Hmm. This is the reason I used %{_sysconfdir}/rc.d/init.d Even if I'll not push the app into EPEL I think it's better to use generic macros. And personally I hate %{_initrddir} because the macro is confusing - it suggests it has something to do with initrd :/ So I'd rather keep %{_sysconfdir}/rc.d/init.d but if you insist - I'll change it to %{_initddir}. I'll prepare new package in the evening (don't have Fedora here). Thanks once again for your help, J. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review