Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477542 --- Comment #17 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-10-27 04:05:12 EDT --- (In reply to comment #16) > @xandry: I changed this using %attr(). Now rpmlint does not complain. I've > installed this package and file permissions are correct. First, I'm afraid, that you should package it as is, w/o changing permissions. There is one possible user case - running mpdscribble as a server on an iron with multiple user accounts, and server's admin would like to hide last.fs account settings from others. Second, I don't see a reason in using killall in %preun section. I think that killing all instances of the app, started by other users, is somewhat improper. Also, I advice you a little simplification. Instead of #init scripts install -d $RPM_BUILD_ROOT/%{_sysconfdir}/rc.d/init.d install -m 0755 %{SOURCE1} $RPM_BUILD_ROOT/%{_sysconfdir}/rc.d/init.d/%{name} you may write install -D -m 0755 %{SOURCE1} $RPM_BUILD_ROOT/%{_sysconfdir}/rc.d/init.d/%{name} or even install -D -m 0755 %{SOURCE1} $RPM_BUILD_ROOT/%{_initddir}/%{name} Please, note, that %{_initddir} is unavailable on RHEL/CentOS, so if you plan to push the application into EPEL also, then you should consider using %{_initrddir} instead. Other things looks sane. Please, comment my notes, and we'll continue our journey. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review