[Bug 477542] Review Request: mpdscribble - A mpd client which submits information about tracks being played to Last.fm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477542





--- Comment #19 from Peter Lemenkov <lemenkov@xxxxxxxxx>  2009-10-27 04:45:54 EDT ---
(In reply to comment #18)

> > > @xandry: I changed this using %attr(). Now rpmlint does not complain. I've
> > > installed this package and file permissions are correct.

> > First, I'm afraid, that you should package it as is, w/o changing permissions.
> > There is one possible user case - running mpdscribble as a server on an iron
> > with multiple user accounts, and server's admin would like to hide last.fs
> > account settings from others.

> You're absolutely right. But on the other hand rpmlint is mandatory step in
> package approval. So how are we going to deal with it?

In this particular case we may ignore this rpmlint message.


> > Please, note, that %{_initddir} is unavailable on RHEL/CentOS, so if you plan
> > to push the application into EPEL also, then you should consider using
> > %{_initrddir} instead.

> Hmm. This is the reason I used %{_sysconfdir}/rc.d/init.d

Then you should (for consistency) change %files section. Instead of 

%{_initddir}/%{name}

you should add

%{_sysconfdir}/rc.d/init.d/%{name}


> So I'd rather keep %{_sysconfdir}/rc.d/init.d but if you insist - I'll change
> it to %{_initddir}.

No, I'm not insisting here - feel free to decide which one to choose by
yourself :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]