Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530205 --- Comment #3 from Sean Middleditch <sean@xxxxxxxxxxxxxx> 2009-10-23 05:05:04 EDT --- I don't believe the patch will break the Windows build, actually. I'm rather surprised that it builds in MSVC and not GCC by default, given my own experience with both compilers; usually it's GCC that pollutes the C++ namespace when you pull in random headers due to its reliance on C headers for implementing libstdc++ and MSVC that requires strict and proper C++ header inclusion. Go figure. :) I'll rename the patch files. I suppose the MingW trick could work, but I'm honestly more included to send the patch upstream as-is to make clearly point out the problem. The Makefile shouldn't be defining its own CXXFLAGS, it should use that name for the external configuration, and another name for internal variables. IMO, anyways. Granted, I'll probably just send upstream an entirely cleaned up Makefile in this case. There are some warnings generated during build I'd like to send him another patch for anyway, and a bug I need to track down (not a showstopper at all, just a little annoying thing with SDL keybindings and the ENTER key). I will add in the examples, not a big deal if you think it's preferable. I put them in the -devel package, since example source doesn't make a lot of sense in the main binary IMO. I copied the iconv thing right out of another example, but I'll fix it up to preserve the timestamp. :) http://middleditch.us/sean/fedora/AntTweakBar/AntTweakBar.spec http://middleditch.us/sean/fedora/AntTweakBar/AntTweakBar-1.13-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review