Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530205 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #2 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-10-22 18:39:02 EDT --- (In reply to comment #0) > > I also had to apply two patches, and these are the first time I've applied > patches with any of my packages, so hopefully I did that part right. Looks good ;) How about using #if defined(linux) || defined(__linux) around the include patch? This way, upstream can apply this and won't break their windows build. The second patch with optflags could be done differently: "MINGWFLAGS="%{optflags}" make" should do the same job. A patch name should be in the format %{name}-whatever.patch. > The only thing I'm particularly unsure about with this package is whether or > not I should put the examples/demos into a sub-package. I'm not sure they're > really useful to people without the source. I've seen a few packages that > include the example source in the docs directory, but I'm not a huge fan of > that approach myself. I decided to just leave them out entirely for now. Some examples are DirectX only, but TwSimpleGLFW, TwSimpleGLUT, TwSimpleSDL, TwAdvanced1 and TwString (only .cpp files) should be included (glfw.h as depency) in the main package as doc, extra doc package only for huge examples and so on, but ~100k is not huge to me ;) When converting to utf8, it is better to preserve timestamps, see http://fedoraproject.org/wiki/PackagingTricks#Convert_encoding_to_UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review