Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502596 --- Comment #5 from Vitezslav Crhonek <vcrhonek@xxxxxxxxxx> 2009-10-13 08:52:02 EDT --- In reply to comment #4) > Sorry for the delay. > > Since the release number wasn't changed, I thought the new sources were not > available yet. > > Few more things to take care of: > 1) #user1 rpmlint > rpmbuild/RPMS/i386/sblim-tools-libra-devel-0.2.3-1.fc10.i386.rpm > sblim-tools-libra-devel.i386: W: no-documentation > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > > Please add some documentation to doc package. The documentation from upstream tarball is shipped in sblim-tools-libra package, there's no more documentation left for -devel package. Because -devel package requires sblim-tools-libra package to be installed, the documentation will be available to the user. > > 2) The devel package seems to own /usr/include/sblim directory. I suggest a > "Requires:" be added to a package which owns this directory. This is just to > make sure that the same directory is not owned by different packages. > > sblim-cmpi-base-devel seems to be a good choice. Please suggest if you have > any other package in mind. I believe this is not necessary and will lead only to pointless dependency. See https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership IMHO this is the case of second example - Multiple packages have files in a common directory but none of them requires others. > > > Please bump up the release number of the package to avoid further confusion. So I did no changes. Please let me know if you have anything else or if you feel I'm wrong with things above. > > > This package is good to go after handling the above comments. > > Thank you > Praveen -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review