Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525759 --- Comment #4 from Thomas Janssen <thomasj@xxxxxxxxxxxxxxxxx> 2009-10-13 08:57:14 EDT --- (In reply to comment #3) > A few comments: > > 1. %files, use instead: > %{_kde4_appsdir}/QtCurve/ > else that dir is unowned Done > 2. %post/%postun scriptlets aren't needed (no shlibs here) I should find a website that educates me to identify shlibs. > 3. use of sed in %prep > I'd prefer (upstreamable) patches here, but we don't need to consider that a > blocker for now. we can sort that out later. Ok, there's only one sed left. And that one is needed for %find-lang %{name} due to the name change. Not sure if upstream would fix that. > 4. can drop extraneous > BR: qt-devel Done > We noticed in #fedora-kde today in testing this, that the windeco is a bit > borked, please notify upstream. Upstream notified. No bug tracker there. kde-look.org own mail interface used. Spec URL: http://thomasj.fedorapeople.org/reviews/qtcurve-kde4.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/qtcurve-kde4-0.69.0-1.fc10.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1743415 -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review