Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522980 --- Comment #2 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2009-09-21 18:31:42 EDT --- (In reply to comment #1) > * ?: source matches upstream > sha256sum 32650b8f35ff57c0ce79aca2ed659f1fe50c50b5237c520ee61518b6c4a05949 Not sure how that happens. I just redownloaded twice: spectool -gf lua-json.spec and verified the old SRPM, and the two downloads. All of them check out: $ sha1sum luajson-1.0.tar.bz2.try1 luajson-1.0.tar.bz2 /home/michel/rpmbuild/SOURCES/luajson-1.0.tar.bz2 ca09374ec38b94573232e82e8b27c960c6f5cd9e luajson-1.0.tar.bz2.try1 ca09374ec38b94573232e82e8b27c960c6f5cd9e luajson-1.0.tar.bz2 ca09374ec38b94573232e82e8b27c960c6f5cd9e /home/michel/rpmbuild/SOURCES/luajson-1.0.tar.bz2 > * FAIL: own all directories > Must contain in %files: > %dir %{luapkgdir}/json > %dir %{luapkgdir}/json/decode > %dir %{luapkgdir}/json/encode Not really: I do own everything under %luapkgdir}. The %dir directive would instruct RPM to own the directory only, without the files within, necessitating additional lines for %{luapkgdir}/json/decode/* and %{luapkgdir}/json/encode/* Best way to check is to do rpm -qpl on the binary RPM itself > * FAIL: macros used consistently > Most of the time you use %{dir} macros, but then you use $RPM_BUILD_ROOT, > should be %{buildroot} Hm. RPM_BUILD_ROOT is allowed, I think. See http://fedoraproject.org/wiki/Packaging:Guidelines#macros what's not allowed is mixing up %{buildroot} and $RPM_BUILD_ROOT within the same spec file. > Preventing approval: > - Directories must be owned > - Consistent macro usage These two are, I think, non-issues. Do let me know; I'll use %{buildroot} if you insist :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review