Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522980 --- Comment #1 from Tim Niemueller <tim@xxxxxxxxxxxxx> 2009-09-21 18:17:35 EDT --- MUST * OK: rpmlint # rpmlint lua-json.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. # rpmlint lua-json-1.0-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # rpmlint lua-json-1.0-1.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. * OK: package name * OK: package version and release * OK: spec file name * OK: package guideline-compliant * OK: license complies with guidelines * OK: license field accurate * OK: license file not deleted * OK: spec in US English * OK: spec legible * ?: source matches upstream sha256sum 32650b8f35ff57c0ce79aca2ed659f1fe50c50b5237c520ee61518b6c4a05949 * OK: builds under >= 1 archs, others excluded * OK: dependencies (requires) * OK: build dependencies complete * N/A: locales handled using %find_lang, no %{_datadir}/locale * N/A: library -> ldconfig * N/A: relocatable: give reason * FAIL: own all directories Must contain in %files: %dir %{luapkgdir}/json %dir %{luapkgdir}/json/decode %dir %{luapkgdir}/json/encode * OK: no dupes in %files * OK: permission * OK: %clean RPM_BUILD_ROOT * FAIL: macros used consistently Most of the time you use %{dir} macros, but then you use $RPM_BUILD_ROOT, should be %{buildroot} * OK: Package contains code * N/A: large docs => -doc * OK: doc not runtime dependent * N/A: headers in -devel * N/A: static in -static * N/A: if contains *.pc, req pkgconfig * N/A: if libfiles are suffixed, the non-suffixed goes to devel * N/A: devel requires versioned base package * N/A: desktop file uses desktop-file-install * OK: clean buildroot before install * OK: filenames UTF-8 SHOULD * OK: if license text missing, ask upstream to include it * N/A: desc and summary contain translations if available * N/A: package build in mock on all architectures lua-lunit not tagged in koji build root, therefore no scratch build possible * ?: package functioned as described %check suggests so, haven't checked myself. * OK: scriplets are sane If %check fails, you should cat testlog.txt such that the user knows what happened. * N/A: other subpackages should require versioned base * N/A: if main pkg is development-wise, pkgconfig can go in main package * OK: require package not files Preventing approval: - Directories must be owned - Consistent macro usage -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review