Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523601 Ionuț Arțăriși <mapleoin@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mapleoin@xxxxxxxxxxxxxxxxx --- Comment #1 from Ionuț Arțăriși <mapleoin@xxxxxxxxxxxxxxxxx> 2009-09-21 18:06:49 EDT --- Hello, I am not in the packager group and will not be able to approve this package. I'm just reviewing. I hope you find this helpful. Here are a few issues I've discovered so far: * As per https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions , tar shouldn't be listed as a BuildRequirement. * Is this an upstream issue? Maybe a link should be provided to clear things up. # Not included till it gets fixed. #%{__tar} -xzf example/SWISH-Stemmer-0.05.tar.gz * The perl module should include the versioned MODULE_COMPAT Requires, as per https://fedoraproject.org/wiki/Packaging/Perl#Versioned_MODULE_COMPAT__Requires I suggest to also use that naming scheme for perl Requires: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides * The devel package should Requires: pkgconfig as per https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#cite_note-pkgconfig-21 * I've also found the following issues with rpmlint: $ rpmlint /var/lib/mock/fedora-11-i386/result/*rpm perl-SWISH.i586: W: no-documentation perl-SWISH.i586: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/SWISH/PhraseHighlight.pm perl-SWISH.i586: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/SWISH/DateRanges.pm perl-SWISH.i586: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/SWISH/DefaultHighlight.pm ...etcetera... swish-e.i586: W: shared-lib-calls-exit /usr/lib/libswish-e.so.2.0.0 exit@xxxxxxxxx swish-e.i586: W: file-not-utf8 /usr/share/man/man1/SWISH-CONFIG.1.gz swish-e.i586: W: file-not-utf8 /usr/share/man/man1/SWISH-FAQ.1.gz swish-e.src:92: E: hardcoded-library-path in %{_prefix}/lib/swish-e/perl/* swish-e.src:95: E: hardcoded-library-path in %{_prefix}/lib/swish-e/*cgi swish-e.src:97: E: hardcoded-library-path in %{_prefix}/lib/swish-e/swishspider swish-e.src:98: E: hardcoded-library-path in %{_prefix}/lib/swish-e/*pl swish-e-debuginfo.i586: W: spurious-executable-perm /usr/src/debug/swish-e-2.4.7/src/expat/xmlparse/xmlparse.h swish-e-doc.i586: W: file-not-utf8 /usr/share/doc/swish-e-doc-2.4.7/pod/SWISH-FAQ.pod swish-e-doc.i586: W: file-not-utf8 /usr/share/doc/swish-e-doc-2.4.7/pod/CHANGES.pod swish-e-doc.i586: W: file-not-utf8 /usr/share/doc/swish-e-doc-2.4.7/pod/SWISH-CONFIG.pod swish-e-perl.i586: W: no-documentation 7 packages and 0 specfiles checked; 24 errors, 9 warnings. I'll be happy to continue this review after these issues are resolved. Time to sleep now ;). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review