Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522980 Tim Niemueller <tim@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Tim Niemueller <tim@xxxxxxxxxxxxx> 2009-09-21 19:03:10 EDT --- (In reply to comment #2) > and verified the old SRPM, and the two downloads. All of them check out: > > $ sha1sum luajson-1.0.tar.bz2.try1 luajson-1.0.tar.bz2 I had given the sha256sum, while you used sha1sum... My bad, I simply forgot to replace ? by OK. So yes, the checksums of your SRPM and the original source do match! > > * FAIL: own all directories > > Must contain in %files: > > %dir %{luapkgdir}/json > > %dir %{luapkgdir}/json/decode > > %dir %{luapkgdir}/json/encode > Not really: I do own everything under %luapkgdir}. The %dir directive would > instruct RPM to own the directory only, without the files within, necessitating > additional lines for %{luapkgdir}/json/decode/* and %{luapkgdir}/json/encode/* I remember being instructed once to explicitly name all directories. But checking some of my other packages confirms your statement. The %dir was used in "special" situations (e.g. in the lua-sql package). So this seems to be ok then. I did check the package contains, but was unsure about possible meta data %dir might record. > what's not allowed is mixing up %{buildroot} and $RPM_BUILD_ROOT within the > same spec file. Yes, that's what I thought before I read the guidelines and how many of my spec files actually look. I leave it up to you. And as said in #522979 I agree with your interpretation of the buildroot guideline (now after I have thought about it a second time...). Since the %dir issue is actually none: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review