Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 ------- Additional Comments From opensource@xxxxxxxxx 2006-09-15 14:44 EST ------- The .desktop file should be in a separate file and not inside the spec. You do not need: Requires(post): desktop-file-utils Requires(postun): desktop-file-utils make install DESTDIR="$RPM_BUILD_ROOT" instead of %makeinstall should work, so you must not use %makeinstall see: http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 You do not package COPYING with contains the license. The license seems to be GPL but you wrote LGPL in the spec. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review