Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-MMagic-XS - Guess file type with XS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205886 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-09-15 14:39 EST ------- You're the license czar so if you feel comfortable importing this then I have no objections. * source files match upstream: b8ce9617527a999c85d54fc8a4e88ebc File-MMagic-XS-0.08.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. ? license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: XS.so()(64bit) perl(File::MMagic::XS) = 0.08 perl-File-MMagic-XS = 0.08-2.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(File::MMagic) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=2, Tests=11, 0 wallclock secs ( 0.06 cusr + 0.01 csys = 0.07 CPU) * no shared libraries are added to the regular linker search paths. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review