Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 ------- Additional Comments From green@xxxxxxxxxx 2006-09-16 16:41 EST ------- (In reply to comment #4) > The .desktop file should be in a separate file and not inside the spec. I decided to delete the .desktop file, as well as the fluidsynth-dssi binary, since it is redundant. FE already has many other ways to run fluidsynth (qsynth, etC). > make install DESTDIR="$RPM_BUILD_ROOT" > instead of %makeinstall should work, so you must not use %makeinstall Fixed. > You do not package COPYING with contains the license. Fixed. > The license seems to be GPL but you wrote LGPL in the spec. Fixed. Updated bits here: Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth-dssi.spec SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-dssi-0.9.1-4.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review