Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtk - The Visualization Toolkit - A high level 3D visualization library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199405 ------- Additional Comments From jamatos@xxxxxxxx 2006-09-12 10:18 EST ------- What is the status of this bug report? Patrice do you want to do a formal review? Some points that I think should be addressed before this packages is accepted, those referred by Patrice like the removal of the patented code are a must. Review for release 11.at: * RPM name is OK * Source vtk-5.0.1.tar.gz is the same as upstream * This is the latest version * Builds fine in mock Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * BuildRequires: gcc-c++ should not be included (wiki: PackagingGuidelines#Exceptions) * Spec file: some paths are not replaced with RPM macros (wiki: QAChecklist item 7) This is relevant in the case of /usr/lib/, is this on purpose? This shows in rpmlint of the source rpm: E: vtk hardcoded-library-path in %{_prefix}/lib/*`" E: vtk hardcoded-library-path in %{_prefix}/lib/* Minor: * QT environment variable are not sourced Looking to the debug file I see that there are source files there: /usr/src/debug/VTK Is this intended? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review