Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libofa - Open Fingerprint Architecture library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204954 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-09-12 10:22 EST ------- Second review: * rpmlint - is not yet silent: W: libofa macro-in-%changelog doc W: libofa mixed-use-of-spaces-and-tabs (this is for src.rpm) W: libofa-devel hidden-file-or-dir /usr/share/doc/libofa-devel-0.9.3/examples/.deps W: libofa-devel hidden-file-or-dir /usr/share/doc/libofa-devel-0.9.3/examples/.deps - Use %%doc, not %doc in %changelog entry. - Remove spaces or tabs in spec file and unify spacing. - examples/.deps is needed? - Well, this wiki page discourages to use unix2dos and actually, unix2dos is not needed. Also, changing the end-of-file encodings of souce files (i.e. .h or .cpp files) is done by: for f in `find . -name README -or -name \*.cpp -or -name \*.h` ; do \ sed -i -e 's|\r||' $f ; done in %prep stage. Then removing DOS-like encoding of patch file (Patch1) can be done. Changing the end-of file encoding of \*.cpp, \*.h files is needed because they are finally included in debuginfo rpm. * Well, removing external dependency from .pc file is correct? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review