Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497441 --- Comment #40 from Igor Jurišković <juriskovic.igor@xxxxxxxxx> 2009-04-29 09:29:20 EDT --- (In reply to comment #39) > Definitely getting there :) > > Right now, all the descriptions are identical. Wouldn't it be better if the > different packages explained what they contained, instead of just a common > description of what Mumble is? Unless you already know, it's not very clear > what "mumble-overlay" does. Changed for everything except for protocol. Dont now what to write. > > You're calling the package "murmur", which provides "mumble-murmur". If you > make it provide "mumble-server" instead (or simply make it the "server" > subpackage), you'll match the naming used in other distros, which means less > confusion :) It's called mumble-server now. > > You're currently renaming the binary from murmurd to murmur. The 'd' is kind of > standard for daemons, and I suggest leaving it. Changed. > > Read the comment about the input-policy file above :) Unless you know it to > work in current revisions of Fedora, I recommend dropping it. To be honest with you I don't even now what it does. I'll put it as documentation so if somebody wants it, it can get it there. > > There needs to be a post-install for murmur/mumble-server that reloads the dbus > service. dbus uses inotify to monitor conf files. They'll get updated automatically. > > You're installing a logrotate, and your murmur.ini contains logging information > for /var/log/murmur, but this directory isn't created anywhere. Same goes for > /var/run/murmur (where murmur will try to store it's pid file) Are you sure about this? I just untared mumble-1.1.8.tar.gz and opened scripts/murmur.ini.system and it says this: logfile=/var/log/mumble-server/mumble-server.log pidfile=/var/run/mumble-server/mumble-server.pid murmur.logrotate first line is: /var/log/mumble-server/mumble-server.log Files coming in about one hour. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review