Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497441 --- Comment #39 from Thorvald Natvig <slicer@xxxxxxxxxxxxxxxxxxxxx> 2009-04-28 20:13:42 EDT --- Definitely getting there :) Right now, all the descriptions are identical. Wouldn't it be better if the different packages explained what they contained, instead of just a common description of what Mumble is? Unless you already know, it's not very clear what "mumble-overlay" does. You're calling the package "murmur", which provides "mumble-murmur". If you make it provide "mumble-server" instead (or simply make it the "server" subpackage), you'll match the naming used in other distros, which means less confusion :) You're currently renaming the binary from murmurd to murmur. The 'd' is kind of standard for daemons, and I suggest leaving it. Read the comment about the input-policy file above :) Unless you know it to work in current revisions of Fedora, I recommend dropping it. There needs to be a post-install for murmur/mumble-server that reloads the dbus service. You're installing a logrotate, and your murmur.ini contains logging information for /var/log/murmur, but this directory isn't created anywhere. Same goes for /var/run/murmur (where murmur will try to store it's pid file) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review