Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492479 --- Comment #1 from Christian Krause <chkr@xxxxxxxxxxx> 2009-04-14 15:44:27 EDT --- I've reviewed your package and it looks quite good. There is one TODO item and I have a small usage question (see below). * rpmlint: OK rpmlint SPECS/razertool.spec RPMS/i386/razertool-* SRPMS/razertool-0.0.7-1.fc10.src.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings. * naming: OK * spec file name: OK * License: OK - GPLv2+: acceptable - matches the actual license - license file packaged * spec file in English and legible: OK * Source0: OK - newest upstream version used - source file matches upstream - md5sum: dad8236b2fface39f054a7ca6d1a448c razertool_0.0.7.orig.tar.gz - spectool -g works * compilation: OK - mock (F10) - koji: F11, F10 and F9 - %{optflags} are used correctly - smpflags used * locale handling: OK * debuginfo: OK - debuginfo files are not empty and can be used in gdb * handling of shared/static libraries, header files, pkgconfig files: OK (n/a) * directory ownership: OK - no directories created - only directories used which are included in the base filesystem * no files listed twice: OK * file permissions and ownership: OK * %clean section: OK * macro usage: OK * code vs. content: OK (only code) * subpackage for large documentation: OK (n/a) * %doc: OK * rm -rf in %install: OK * filenames UTF8: OK * desktop file: OK - it may be debatable in which menu the razortool appears (Preferences vs. Administration), but since it changes the configuration values globally (in the mouse), Administration seems the best option... * buildrequires: OK * scriptlets: OK * final requires: OK * functional test: TODO - programs run without segfault ;-) - since I don't have such a device, I can't do a full functional test - razertool-gtk doesn't find its icon: ** (razertool-gtk:12930): WARNING **: Couldn't find pixmap file: razertool-icon.png This is caused by moving the pixmaps in the spec file (the program will search the icon in the old place). I would suggest the following: - don't move %{_datadir}/%{name}/pixmaps, but package %{_datadir}/%{name} completly - use the full path to the icon in the *.desktop file (That's OK according to http://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files) Additionally I have one (optional) question: I've seen that libusb tries to open the files in /dev/bus/usb/*/*. On my system the user has no write permissions to any of these files (not even the one of the mouse). Is there a need to run this program as root or do you have to explicitly change the permissions of these files? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review