Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483543 --- Comment #18 from Lubomir Rintel <lkundrak@xxxxx> 2009-04-14 15:50:16 EDT --- - compiler flags used correctly - spec file clean, legible, using American english - filelist sane - builds fine in mock 1.) Don't override reqprov generator please AutoReqProv: no 2.) This is useless, coreutils is in the build group (see "koji list-groups dist-f11-build") BuildRequires: coreutils 3.) Don't strip the binary Debuginfo generator will do that strip stapgui-server 4.) Please use %{_smp_mflags} make flags make 5.) You don't need to redundantly set 0755 mode 0755 is install's default anyways Moreover, you have a duplicate entry in filelist install -m0755 stapgui-server ${RPM_BUILD_ROOT}/%{_bindir}/stapgui-server ... %{_bindir}/* ... %attr(0755,root,root) %{_bindir}/stapgui-server 6.) RPMlint whines Both problems failry simple to fix Source package: systemtapguiserver.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 2) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. And lots of these for debuginfo: systemtapguiserver-debuginfo.i586: W: spurious-executable-perm /usr/src/debug/systemtapguiserver-1.0/logger.cpp The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review