Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489633 --- Comment #6 from Michael Ploujnikov <ploujj@xxxxxxxxx> 2009-03-14 13:18:05 EDT --- (In reply to comment #2) > The %{_mingw32_configure} line needs to be moved down so it > is in the %build section. > > Also you don't need %pre and %post, because ldconfig only cares > about native Fedora binaries, and won't know what to do with > *.DLLs. Just remove the %pre and %post sections completely. > > I will continue the review assuming that you have done the above. Done (In reply to comment #3) > auto-buildrequires suggests the following extra > BuildRequires lines: > > BuildRequires: mingw32-dlfcn This is definitely needed since physfs can use dlopen(). > BuildRequires: mingw32-readline This is only required for the test program > BuildRequires: mingw32-zlib Physfs can use an internal zlib if this isn't available. I suspect it would be better for security updates to have physfs use the system's zlib rather than its own. (In reply to comment #4) > rpmlint output: > > mingw32-physfs.src:66: E: files-attr-not-set > mingw32-physfs.src:67: E: files-attr-not-set > mingw32-physfs.src:68: E: files-attr-not-set > mingw32-physfs.src:69: E: files-attr-not-set > mingw32-physfs.src:70: E: files-attr-not-set > > You are missing a %defattr line in the specfile Fixed, although my rpmlint (0.85) didn't mention this. (In reply to comment #5) > Also why are we not building the latest upstream > version, which is 1.1.1? Version 1.1.1 uses cmake, which I haven't figured out how to use with mingw32 yet. Version 1.1.0 still uses autotools so I'll try creating a .spec file for that one, later. The reasons I chose 1.0.1 originally is because the latest Fedora development version still uses 1.0.1: http://cvs.fedoraproject.org/viewvc/devel/physfs/physfs.spec?revision=1.9&view=markup . I've updated http://plouj.com/rpmbuild/SPECS/mingw32-physfs.spec and http://plouj.com/rpmbuild/SRPMS/mingw32-physfs-1.0.1-11.fc10.src.rpm with all of the above fixes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review