Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489633 --- Comment #5 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2009-03-13 12:30:04 EDT --- - rpmlint output see comment 4 + package name satisfies the packaging naming guidelines + specfile name matches the package base name - package should satisfy packaging guidelines problems, see comment 2, comment 3, comment 4 + license meets guidelines and is acceptable to Fedora zlib + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible ? upstream sources match sources in the srpm 9bab1ed6383958b8bc7db792c6989b01 663342 (upstream website was being very slow - I will check this later) + package successfully builds on at least one architecture n/a ExcludeArch bugs filed ? BuildRequires list all build dependencies see comment 3 n/a %find_lang instead of %{_datadir}/locale/* + binary RPM with shared library files must call ldconfig in %post and %postun this doesn't apply for mingw packages, see comment 2 + does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files - %defattr line see comment 4 + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel doesn't apply to mingw packages n/a static libraries should be in -static could consider creating a -static subpackage, but not vital n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file n/a packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock + the package should build into binary RPMs on all supported architectures - review should test the package functions as described n/a scriptlets should be sane n/a pkgconfig files should go in -devel n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin ------------------------ Please see comment 2, comment 3, comment 4. Also why are we not building the latest upstream version, which is 1.1.1? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review