Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482884 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-03-07 14:33:21 EDT --- This is so horrible. And perverse. Which makes the package absolutely essential. It builds and installs fine for me. I haven't the slightest idea how to make it do anything, and frankly I don't want to learn for fear of mental contamination. Some comments: There's no need at all for the Group: tag in the subpackage, unless you want it to be different from the main package. In this case it's just pointless. I would urge the lower-casing of the package name, as Debian seems to do. I have some concerns about /usr/bin/sick as being insufficiently unique. A search turns up no instances anywhere except in the Debian package, so it seems low risk, but I wonder if it's worth it for what's essentially a joke package. I'm going to leave that up to you. You can read http://fedoraproject.org/wiki/Common_package_names_packaging_guideline_draft for guidance; it's still being drafted, but should grow to encompass potentially conflicting executables as well. I tried parallel make but the package then fails to build. Please add a comment to this effect so that folks looking to save a bit of build time won't be tripped up as I was. It's not immediately clear how the UI-X subpackage provides a graphical interface. I guess the other executables look for the presence of the X module and use it if present. Is it reasonable to provide a desktop file and an icon in that case? * source files match upstream. sha256sum: 6f3db1dc35c9217c6590007238d444e30730ee021b4ea4338b26bdb7b8ff29ac CLC-INTERCAL-1.-94.-2.tar.gz * package meets naming and versioning guidelines (as much as is possible) I suggest downcasing the package name. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: CLC-INTERCAL-0-0.0.1._94._2.fc11.noarch.rpm perl(Language::INTERCAL::ArrayIO) perl(Language::INTERCAL::Arrays) perl(Language::INTERCAL::Arrays::Hybrid) perl(Language::INTERCAL::Arrays::Tail) perl(Language::INTERCAL::Backend) perl(Language::INTERCAL::Backend::ListObject) perl(Language::INTERCAL::Backend::Object) perl(Language::INTERCAL::Backend::Perl) perl(Language::INTERCAL::Backend::Run) perl(Language::INTERCAL::ByteCode) perl(Language::INTERCAL::Charset) perl(Language::INTERCAL::Charset::Baudot) perl(Language::INTERCAL::Charset::EBCDIC) perl(Language::INTERCAL::Charset::Hollerith) perl(Language::INTERCAL::CrawlingHorror) perl(Language::INTERCAL::DataItem) perl(Language::INTERCAL::Distribute) perl(Language::INTERCAL::DoubleOhSeven) perl(Language::INTERCAL::Exporter) perl(Language::INTERCAL::Generate) perl(Language::INTERCAL::GenericIO) perl(Language::INTERCAL::GenericIO::ARRAY) perl(Language::INTERCAL::GenericIO::COUNT) perl(Language::INTERCAL::GenericIO::FILE) perl(Language::INTERCAL::GenericIO::OBJECT) perl(Language::INTERCAL::GenericIO::REMOTE) perl(Language::INTERCAL::GenericIO::STRING) perl(Language::INTERCAL::GenericIO::TCP) perl(Language::INTERCAL::GenericIO::TEE) perl(Language::INTERCAL::GenericIO::UFILE) perl(Language::INTERCAL::GenericIO::UTCP) perl(Language::INTERCAL::HostIP) perl(Language::INTERCAL::InstallModule) perl(Language::INTERCAL::Interface) perl(Language::INTERCAL::Interface::Curses) perl(Language::INTERCAL::Interface::Line) perl(Language::INTERCAL::Interface::Line::IN) perl(Language::INTERCAL::Interface::Line::WOBJ) perl(Language::INTERCAL::Interface::None) perl(Language::INTERCAL::Interface::common) perl(Language::INTERCAL::Interpreter) perl(Language::INTERCAL::Numbers) perl(Language::INTERCAL::Numbers::Spot) perl(Language::INTERCAL::Numbers::Twospot) perl(Language::INTERCAL::Object) perl(Language::INTERCAL::Optimiser) perl(Language::INTERCAL::Parser) perl(Language::INTERCAL::Rcfile) perl(Language::INTERCAL::ReadNumbers) perl(Language::INTERCAL::Reggrim) perl(Language::INTERCAL::Server) perl(Language::INTERCAL::SharkFin) perl(Language::INTERCAL::Sick) perl(Language::INTERCAL::Splats) perl(Language::INTERCAL::SymbolTable) perl(Language::INTERCAL::Theft) perl(Language::INTERCAL::Whirlpool) perl(Language::INTERCAL::WriteNumbers) CLC-INTERCAL = 0-0.0.1._94._2.fc11 = /usr/bin/perl perl >= 0:5.005 perl(Carp) perl(Config) perl(Curses) perl(Exporter) perl(ExtUtils::MakeMaker) perl(File::Basename) perl(File::Spec) perl(File::Spec::Functions) perl(FindBin) perl(Getopt::Long) perl(IO::File) perl(IO::Socket::INET) perl(Language::INTERCAL::ArrayIO) perl(Language::INTERCAL::Arrays) perl(Language::INTERCAL::Backend) perl(Language::INTERCAL::Backend::Object) perl(Language::INTERCAL::ByteCode) perl(Language::INTERCAL::Charset) perl(Language::INTERCAL::Charset::Baudot) perl(Language::INTERCAL::CrawlingHorror) perl(Language::INTERCAL::DataItem) perl(Language::INTERCAL::DoubleOhSeven) perl(Language::INTERCAL::Exporter) perl(Language::INTERCAL::GenericIO) perl(Language::INTERCAL::GenericIO::FILE) perl(Language::INTERCAL::GenericIO::TCP) perl(Language::INTERCAL::HostIP) perl(Language::INTERCAL::Interface) perl(Language::INTERCAL::Interface::common) perl(Language::INTERCAL::Interpreter) perl(Language::INTERCAL::Numbers) perl(Language::INTERCAL::Object) perl(Language::INTERCAL::Optimiser) perl(Language::INTERCAL::Parser) perl(Language::INTERCAL::Rcfile) perl(Language::INTERCAL::ReadNumbers) perl(Language::INTERCAL::Reggrim) perl(Language::INTERCAL::Server) perl(Language::INTERCAL::SharkFin) perl(Language::INTERCAL::Sick) perl(Language::INTERCAL::Splats) perl(Language::INTERCAL::SymbolTable) perl(Language::INTERCAL::Whirlpool) perl(POSIX) perl(Socket) perl(Term::ReadLine) perl(constant) perl(strict) perl(vars) CLC-INTERCAL-UI-X-0-0.0.1._94._2.fc11.noarch.rpm perl(Language::INTERCAL::Interface::X) CLC-INTERCAL-UI-X = 0-0.0.1._94._2.fc11 = CLC-INTERCAL = 0-0.0.1._94._2.fc11 perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Gtk2) perl(Language::INTERCAL::Exporter) perl(Language::INTERCAL::Interface::common) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=15, Tests=6131, 17 wallclock secs ( 0.96 usr 0.10 sys + 15.77 cusr 0.77 csys = 17.60 CPU) All tests successful. Files=7, Tests=148, 7 wallclock secs ( 0.05 usr 0.02 sys + 0.36 cusr 0.06 csys = 0.49 CPU) All tests successful. Files=3, Tests=12, 0 wallclock secs ( 0.01 usr 0.02 sys + 0.20 cusr 0.02 csys = 0.25 CPU) All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.14 CPU) All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.13 cusr 0.02 csys = 0.16 CPU) All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.16 cusr 0.03 csys = 0.21 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. ? possible generically named files (/usr/bin/sick) * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. ? Maybe there should be a desktop file and icon in the UI-X subpackage. The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review