Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482884 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |CLC-INTERCAL - Compiler for |clc-intercal - Compiler for |the INTERCAL language |the INTERCAL language --- Comment #4 from Iain Arnell <iarnell@xxxxxxxxx> 2009-03-08 05:48:51 EDT --- Thanks for the review. And I will start to reciprocate now that I've got a few under my belt. I agree with lowercasing - better aesthetically and consistent with debian. I've kept the group tag in the sub-package since at least on my setup, rpm is making it 'unspecified' if I don't (and I think rpm 4.4 requires it, so may still be necessary for F-9?). I'm happy with /usr/bin/sick - it certainly seems to be unique at the minute and should a possible conflict occur in future, I don't see too many problems if we do need to rename it later (anyone relying on intercal has more serious problems to worry about). You're absolutely right about the UI-X sub-package. I've added a sentence to its description to make this clearer. I'm not sure that a desktop file is necessary, though. New spec: http://iarnell.fedorapeople.org/rpms/clc-intercal.spec New SRPM: http://iarnell.fedorapeople.org/rpms/clc-intercal-0-0.1.1._94._2.fc11.src.rpm New koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1229460 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review