Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: auriferous - Game inspired by the classic Loderunner https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199797 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-07-31 02:32 EST ------- (In reply to comment #2) > MUSTFIX > ======= > * Missing BR: libpng-devel, or is this supposed to be pulled in > automatically by ClanLib06-devel? > Yes that is a missing Requires in ClanLib06-devel, I've fixed this and the new ClanLib06 is building on the buildsys as I type. Sigh, I manually checked all the ClanLib06 headers for things like this, but appereantly I've read over the #include <png.h> . > SHOULD > ====== > * Too many smileys in the %description. You're right I've copy and pasted that from the homepage. I've removed the smileys. > * Consider moving %{_datadir}/auriferous to a -data subpackage Unless upstream has the data in a seperate package too that is a useless exercise, since any bugfixes to the engine part will require a rebuild of the SRPM and thus will result in a new data subpackage packages too, so a user doing a yum update will still download all the unchanged data files along with the bugfixed engine. I wouldn't mind a solution for this, but as is creating a data subpackage and then Requiring it from the main package has no advantages. > > NOTES > ===== > * The display size is slightly larger than my 800x600 setup, making it > somewhat awkward. I didn't see any in-game options to change the display > size, is that possible? I've taken a look and everything is hardcoded to 1024x768 using pixel coordinates, so I'm afraid I cannot (with reasonable effort) fix this. > * What's the difference between playerr.png in the tarball and your > modified playerr.png? My version adds one additional column of transparant pixels to the right (gimp), upstream it is one column to small causing memory curruption (clanlib really should complain, but instead it accesses random memory). It took me quite a bit of time to hunt this down. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review