Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-POE-Component-Logger https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198023 ------- Additional Comments From rc040203@xxxxxxxxxx 2006-07-08 23:48 EST ------- (In reply to comment #3) > (In reply to comment #1) > > package is noarch > > > > => OPTIMIZE="%{optflags}" > > is unused/superfluous. > > > > => This find also is very likely unnecessary: > > find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';' > > > > Chris, Jason, this is a systematic bug in most (all) of Chris's perl packages. > > How is this a "bug"? It's part of the standard perl specfile template, @Cris: Start thinking about what you are doing! > doesn't conflict with any of the packaging guidelines, If you were around to perl packaging in Fedora a little longer, you'd know that not using OPTIMIZE and dropping the find had been part of older Fedora perl templates. For reasons unknown to me, this somehow has fallen out of the current templates. > and it certainly isn't doing any harm. Perl makefiles are generated on the fly, therefore you never can be sure what they are doing. Are you sure the package's author hasn't added a custom VAR named OPTIMIZE? Are you sure the perl-magic a package uses, suffers from a bug and abused OPTIMIZE? => They are likely not to do any harm, but certainly not "certainly". -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review