[Bug 198023] Review Request: perl-POE-Component-Logger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-POE-Component-Logger


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198023





------- Additional Comments From tibbs@xxxxxxxxxxx  2006-07-08 21:02 EST -------
For noarch packages, passing OPTIMIZE is pointless as the compiler isn't called,
and perl will never create .bs files.  Ralf says including them is a bug, which
is rather ludicrous; I just call them cruft that doesn't need to be there but
which doesn't hurt.  If you were inventing random needless things and sticking
them in the spec then I would see an issue, but these are verbatim from the
specfile template and honestly I don't see how you coule expect anyone but an
expert to know that the find line is always needless for a noarch package.

If it were my package, I would remove the cruft because I'd want the spec to be
as simple as possible.  I don't expect and certainly don't require that everyone
else do the same thing; keeping things as close as possible to the template also
has its benefits.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]