Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-sqlite3 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193071 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-08 23:26 EST ------- (In reply to comment #6) > I wanted to keep it close to the entry in Config::CONFIG those get set from. Do > you think the resulting macro names are too long ? I don't think the length is a problem; what is at issue is the fact that what's in the current guidelines doesn't match what's being done here. The first approved Ruby package should follow the spec rather closely, I think. So, if you want to keep it close to what's in Config::CONFIG, then the guidelines don't reflect that and need to be changed, assuming it's not too late to do that. Finally, you use "%{__chmod}" instead of just plain "chmod", but don't use "%{__rm}". Any reason for using just one obsfucating macro? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review