Re: extras-buildsys/utils extras-sign-move.py,1.11,1.12

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2006-04-23 at 21:55 +0300, Ville Skyttä wrote:
> On Sun, 2006-04-23 at 11:40 -0700, Seth Vidal wrote:
> 
> > Modified Files:
> > 	extras-sign-move.py 
> > Log Message:
> > 
> > if the file already exists, unlink it - this lets us sneak out silent
> > changes
> [...]
> >                  if not DEBUG:                
> > +                    if os.path.exists(rpmloc):
> > +                        os.unlink(rpmloc)
> >                      shutil.copy2(package, rpmloc)
> 
> Eh... rationale?  We should be making sure that this _cannot_ happen,
> not make it easier or automatic.

in this specific case I added it b/c some num-num updated their packages
w/o iterating the release. So we ended up with a conflict. If you'd like
to reverse it - so that we trust the repo over the just-built - that's
fine - just make it:

if os.path.exists(rpmloc):
    os.unlink(package)

then skip the shutil.copy2()
that'll work just as well, though, to be clear - I think it would be
handy to be able to overwrrite a change.

-sv


-- 
fedora-extras-list mailing list
fedora-extras-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-extras-list

[Index of Archives]     [Fedora General Discussion]     [Fedora Art]     [Fedora Docs]     [Fedora Package Review]     [Fedora Desktop]     [Big List of Linux Books]     [Yosemite Backpacking]     [KDE Users]

  Powered by Linux