Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bmpx - Media player with the WinAmp GUI https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187351 ------- Additional Comments From matthias@xxxxxxxxxxxx 2006-04-11 05:17 EST ------- About the needs work : - That build root is plain silly with the chroot builds we have nowadays, and is the "preferred" according to the wiki. It makes mach builds fail, so it's not the one I use. - Please detail what paths aren't replaced, as I can't identify any at a first glance. - %{__rm} -rf %{buildroot} is already present right after %install... - If you look closer, gettext-devel is build required already... - COPYING added... it was missing from the tarballs some time ago IIRC. - I understand the guidelines as "if there is no desktop files, then include one and install it this way", but since the included desktop file is fine IMHO, I didn't touch it. If my interpretation is wrong, alright, but the Wiki section will need some more details. - update-desktop-database calls will be added, good catch! Updated package 0.14.3-2 available now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
