Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bmpx - Media player with the WinAmp GUI https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187351 ------- Additional Comments From eric.tanguy@xxxxxxxxxxxxxx 2006-04-10 16:18 EST ------- Review for release 1.fc5: * RPM name is OK * Source bmpx-0.14.3.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint of bmpx-devel looks OK * rpmlint of bmpx looks OK * File list of bmpx-devel looks OK * INSERT RESULT OF RUN TEST Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Spec file: some paths are not replaced with RPM macros (wiki: QAChecklist item 7) * The BuildRoot must be cleaned at the beginning of %install * BuildRequires: gettext is missing (required by the %find_lang macro) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) * Desktop file: vendor should be fedora (wiki: PackagingGuidelines#desktop) * Desktop file: the Categories tag should contain X-Fedora (wiki: PackagingGuidelines#desktop) * Scriptlets: missing update-desktop-database (wiki: ScriptletSnippets) Minor: * Duplicate BuildRequires: dbus-devel (by hal-devel), gtk2-devel (by libglade2-devel) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
