Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argus-2.0.6.fixes.1-1.src.rpm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182966 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-03-05 18:38 EST ------- A review: MUST items: OK - Package name. OK - Spec file name matches. OK - Package guidelines. OK - Licsense. OK - License field matches in spec. OK - License included in files OK - Spec in american english OK - Spec legible OK- Md5sum of source from upstream b90b8ea951fd0e2193b9a6bab565a139 argus-2.0.6.fixes.1.tar.gz b90b8ea951fd0e2193b9a6bab565a139 ../argus-2.0.6.fixes.1.tar.gz 59f65159070f849211685513384fa90f argus-clients-2.0.6.fixes.1.tar.gz 59f65159070f849211685513384fa90f ../argus-clients-2.0.6.fixes.1.tar.gz OK - No Forbidden buildrequires included OK - All required buildrequires included? OK - Owns all directories it creates. OK - No duplicate files in %files listing. OK - Permissions on files correct. OK - Clean section correct. OK - Macros consistant. OK - Code not content. OK - Docs must not affect runtime. OK - Doesn't own any files/dirs that are already owned by others. Blockers: 1. Some rpmlint output: This might be due to the name having 'lib*' in it: E: argus explicit-lib-dependency libpcap Should be installed with non executable permissions: (currently 755, should be 644?): E: argus script-without-shellbang /usr/share/doc/argus-2.0.6.fixes.1/support/Config/argus.conf E: argus script-without-shellbang /usr/share/doc/argus-2.0.6.fixes.1/support/System/crontab E: argus script-without-shellbang /usr/share/doc/argus-2.0.6.fixes.1/support/Deployment/sample E: argus script-without-shellbang /usr/share/doc/argus-2.0.6.fixes.1/support/System/magic Should we use /var/argus? or should that be /var/lib/argus? W: argus non-standard-dir-in-var argus Can be ignored ('install' in comment) W: argus dangerous-command-in-%post install By default the service should be disabled on install... W: argus service-default-enabled /etc/rc.d/init.d/argus 2. There are some build issues. If you have the # prevent perl modules in contrib from being checked for dependencies %define __perl_requires /bin/true %define __perl_provides /bin/true lines in the spec, rpm fails to build with: getOutputFrom(): Broken pipe This is to work around a .pm file in contrib triggering lots of perl dependencies. Possible options: - Don't package contrib script. - Re-name to something besides .pm file? - Some more clever alternative that some perl/rpm guru comes up with? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list