Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: facter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182064 ------- Additional Comments From bugs.michael@xxxxxxx 2006-02-27 11:04 EST ------- $ rpmls facter -rwxr-xr-x /usr/bin/facter -rwxr-xr-x /usr/lib/site_ruby/1.8/facter.rb drwxr-xr-x /usr/share/doc/facter-1.1.1 -rw-r--r-- /usr/share/doc/facter-1.1.1/CHANGELOG -rw-r--r-- /usr/share/doc/facter-1.1.1/COPYING -rw-r--r-- /usr/share/doc/facter-1.1.1/INSTALL -rw-r--r-- /usr/share/doc/facter-1.1.1/LICENSE -rw-r--r-- /usr/share/doc/facter-1.1.1/README It has a direct dependency on "ruby-libs", which owns the /usr/lib/*ruby/1.8 directory tree. That "ruby" requires "ruby-libs" already, well, ugh. * The facter.rb script should not be executable. Gives ugly errors without a ruby shebang. * The install location of the script (/usr/lib/site_ruby/1.8/) looks wrong. IMHO, it should be $ ruby -rrbconfig -e 'puts Config::CONFIG["rubylibdir"]' /usr/lib/ruby/1.8 instead, just like we install Perl modules into vendor locations, as site locations take precendence in search path list. * "Source0" tag should include full URL of tarball: http://reductivelabs.com/downloads/facter/facter-1.1.3.tgz * Repeating the program name in the "Summary" is commonly considered bad taste/style, since what counts and is most interesting is what the stuff in the package does, not its name. Summary: Ruby module for collecting simple facts about a host operating system The package description can expand on that, and at least the %description hould explain that this is a module written in "Ruby". * facter 1.1.3 has been released. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
