Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libopts https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182678 rc040203@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |rc040203@xxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From rc040203@xxxxxxxxxx 2006-02-24 04:01 EST ------- NEEDSWORK: This spec is rather immature and needs quite some work - For the moment, I presume you are new to rpm packaging ;) For the moment, let me only mention a few major issues: 1. Replace the mkdir/install stuff with make DESTDIR=${RPM_BUILD_ROOT} install 2. Use %{_infodir} instead of %{_datadir}/info in %files 3. Missing %{_includedir}/autoopts in %files 4. Split the package into *-devel and nondevel. 5. Package ships infos but no calls to install-info 6. Wrong license ... [libopts is LGPL or BSD cf. http://autogen.sourceforge.net/doc/autogen_185.html#SEC185 ... and many further details ... I'll try to provide a patch addressing the most severe issues ... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
