Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: charis-fonts - Charis SIL fonts https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181993 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-02-18 14:54 EST ------- This is a nice, clean package; you should consider submitting a specfile template for fonts. Upstream's download system is annoying, but that's not your fault and you at least provided instructions for getting the source. rpmlint says: W: charis-fonts invalid-license SIL Open Font License W: charis-fonts wrong-file-end-of-line-encoding /usr/share/doc/charis-fonts-4.0.02/CharisSIL4FontDocumentation.pdf The license is acceptable; it's probably worth opening a bug against rpmlint to get it added. The second warning is just rpmlint being dumb; there's no point in paying attention to line endings in a PDF file. Anyway: rpmlint output is fine. The package meets the naming and packaging guidelines. The specfile is properly named and follows rather exactly that of a previously accepted package. The source file matches upstream. The license is appropriate and included as %doc. Approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
