Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Mud Magic Client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176200 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-01-25 13:57 EST ------- The best way to check BuildRequires is I think to use mock (http://fedoraproject.org/wiki/Legacy/Mock). This builds your package in a minimal chroot with only your additionally-specified build-requirements added, so if you've missed anything it usually causes the build to fail (or sometimes produce packages that are missing features). Other suggestions: * Don't use an Epoch: tag if it's going to be "0" * Use Release: 0.4%{?dist} rather than Release: 0.fdr.4 * Replace "1.8" with "%{version}" in the Source: tag for easier spec maintenance * The %configure macro should set CFLAGS so there's no need to do it yourself * Use e.g. "%post -p /sbin/ldconfig" rather than "%post" and "/sbin/ldconfig" on separate lines * Add changelog entries for your changes so it doesn't look like the last change was by Michael Schwendt in 2004 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
