Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: AutoScan - A utility for network exploration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178932 somlo@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |somlo@xxxxxxx ------- Additional Comments From somlo@xxxxxxx 2006-01-25 13:33 EST ------- You should probably include a direct url for the spec file in addition to the src.rpm. You're mixing $RPM_BUILD_ROOT and %{buildroot}. Either is fine, but pick one and be consistent. You should probably not install doc/AutoScan/* into %{buildroot} during %install, but rather just mention it using '%doc Data/doc/Autoscan' in the %files section. Zooming out to the bigger picture, you probably want separate subpackages for AutoScan_Agent (at least if it's supposed to run independently of, and comunicate with, the main system). you should also add a %changelog section at the end, and document revisions to your .spec file in there. There's probably more, but this should get you started... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
